r635

[Konata]

Well, I'm not good in sources and stuff, but it seems that there is a r635 version in SVN. Does anybody know if it's playable and stable? And can it be used as the base for user modification? IMHO this game has the potential to become particularly anything, from economic strategy to non-linear RPG and VN.

[trex]

It hasn't been compiled, so no, it's not a fully developed release, and as you can see, those few files worked on for r635 are from 3-4 months ago. As you know there's r612 that has been compiled and released, for those interested, it can be found here: http://pinkpetal.org/index.php?topic=773.0


That release fixes corruption in save games where you get close to having over 280 items in your item list. (The game limit is 300). Let us know if it has any other changes, or bugs!



The big hurdle for development, at least months ago was that the devs agreed a conversion to xml format (from the existing code) would make future modders jobs much easier, and that they would then make solid tools compatible for the new code. The conversion is a big task, and it hasn't, and may never be completed.


At this stage, if you're inclined to, creating scripts out of the tools we do have availabe would be a nice addition to the game as there are very few scripted events for the game, and I don't think it's likely now any modded scripts would be rendered broken by the xml conversion. (They would be if it does go ahead, but at this stage, it's more of a question IF now then WHEN)

[Konata]

Good, r612 is still better than r593 
Of course, new scripts will be useful for game, but I thought about other changes too. For example, girls definetely need more various skills, stats and traits, and that can be implemented only through source code editing.
But if conversion to XML will be done soon, there is no point of making this changes, yes. If I understood you properly, all game configs will be converted from C++ to external XML files? I also heard rumors here about developers with no motivation to worf further.
Sorry, English is not my native language and expressing my ideas using it is not easy

[Konata]

Update. r635 compiled, looks like it works properly. Without revision.h and its functions, though. I had problems with this include.

[trex]

So with r635, what's different from r593?


I don't know how far along the conversion is, and if it will be completed, someone from the Dev team will have know more. It has been a long time, but it could still be a possibility that it will still be done. That's why I think scripts are a safe and less work intensive thing to add to the game. You could work on editing the source for more significant changes, but like you said, it could be incompatible.

[Konata]

Full changelog from devs here:

Updated: 1st Feb 2011

### r596 - Depreciated ###

### 599 - docclox ###
* Some tweaks to get this to build under Linux once again.

### 600 - Dagoth ###
* Updated VC++ 2008 project files

### 612 - WD ###
- cPlayer
* Added function cPlayer::Scale200 to change behaviour for player stats: m_Suspicion,  m_Disposition and m_CustomerFear
* Added function cPlayer::SetToZero() to reset player stats
* Checked all reference to cPlayer:: functions and stats and changed to inline getter/setters as needed

- cEvents
* Moved cEvent::CONSTANTS to Constants.h
* Added new events EVENT_GANG, EVENT_BROTHEL
* Added LISTBOX_COLOURs to Constants.h
* Added variable in CEvent::m_Ordinal to use for sorting event order
* Updated IsUrgent(), IsDanger(), IsWarning() in CEvent
* Added new getter functions in CEvent:: TitleText() and ListBoxColour() to simplify Turnsummary() code
* Added new functions in cEvents::IsEmpty() to simplify Turnsummary() code
* Added functions cEvents::DoSort(), cEvents::MakeOrdinal() and CEvent::CmpEventPredicate() to allow sorting of the event vector
* checked all calls to CEvents:: and replaced magic numbers with event CONSTANTS

-InterfaceProcesses::TurnSummary()
* myrikhan code for girls applied to all catorgories
* Simplified code by using new Event getters.
   NOTE: Message Title text is set in CEvent::TitleText() and Listbox Colours in CEvent::ListBoxColour()
* Used new function cEvents::DoSort() to sort events so that the correct event details are displayed on selection.
* Added Dungeon Girls goto button code.
* Added new warning messages for girls in cBrothel:: and cDungeon:: for health and tiredness to take advantage of myrikhan's display code.

- New Torture Class
* Split CBrothel class ->> cPlayer, cBrothel, cDungeon
* Added cGirlTorture adn cGirlGangFight from doclox branch
* Updated VC++ project files only 2010 tested
* Moved all torture code to cGirlTorture, same code for both player torture and girl job torture

- new Config Options
* added TortureTraitWeekMod to Inital and LogTorture to debug in config.xml

- Bugfix
* cBrothelManager::suss_text() to use Susipicion not Disposition
   
### r613 - WD ###
- Bugfix
* Update return values in cJobManager::WorkExploreCatacombs() so summary messages for job refusal is not generated incorrectly.

### r614 - WD ###
* added this changlist

### r625 - WD ###
- Code cleanup / bughunting
* Consolidate all Stats, Skills and Statuses strings to sGirl:: using defined constants not magic numbers
* Added missing Status Map code
* Moved map code to existing unused function sGirl::setup_maps()

* Remove code from sEffect:: to reference sGirl::

* Replaced all enum GIRL_ to const unsigned int STATUS_

### r626 - WD ###
* added this changlist

### r628 - WD ###
- bugfix
* Bugfix cGirls::child_is_grown() as reported by chronos in http://pinkpetal.org/index.php?topic=416.msg11968#msg11968

### r631 - WD ###
- bugfix
* fixed error in sGirl::max_statuses giving size of skills not status (copy paste error)

### r634 - WD ###
* Tidy double if in cGirlTorture::DoTorture()

About conversion, I think that developing team should give a hint whether or not we should wait it. I mean, several motivated modders can do a lot of things instead of waiting new code.

[trex]

So, this r635, does it have a d/l link like r612 did in ghen's post (here:http://pinkpetal.org/index.php?topic=773.0)?


Or do you get the new files from the trunk and slot them into their respective places? (doesn't it need to be compiled/built though to integrate the changes?)

[Konata]

Just downloaded the latest trunk directory and compiled it with Visual Studio 2010. Got new exe (obviously). Also, there is a code and file (.cpp) for new job, Fluffer (what?), but after built it didn't appear in game.

[trex]

Ok, do you have a copy of r635 you could upload?


Fluffer was a job that was part of the Erotic Films jobs (there was a few, I think acting in, fluffing, and being part of the crew were the jobs needed to make a film) If you have a copy of 1.29 or older, you could make films and make good money off it. They made new jobs and made it more complex to make films in 1.30, but they never got it to work (always making serious bugs) so they disabled those jobs. That's why they still don't show up in-game.


A fluffer is a person who keeps the porno stars in films aroused when they are waiting for the crew to set up the next scene. Maybe you already knew, but if not, that's what a fluffer does.

[Konata]

Uploading .exe will be enough?

[trex]

Well I don't have software to build the version out of, so if you have a copy of the version you have compiled and upload it, that'd be perfect.

[Konata]

Let's try! Here is compiled exe from r635.  Backup your original exe and overwrite with this one. If all goes ok, there will be new skill (Morality), just added by me for future, not implemented in game mechanics.


http://www.mediafire.com/?m6rtuss75ftbrhr

[trex]

Thanks konata! I tried it out just now, it did work, but only when I started a new game. I did see the morality stat for the girls, so it was working.
I got 'something went wrong with cc.brothel name' when I loaded save games from previous versions (r593/r485 save games)

[Konata]

There is nothing I can do with saving compatibility. Maybe, your problem apperas due to changing code elements, removing or merging includes. I didn't touch files with name "Brothel", that's for sure. BTW, what about idea of adding more skills? Even Slave Maker has a lot of them, but not enough, I think. Someone could try this, if interested. I could, but have no experience.

[recreation]

@konata: how did you get that uncompiled 1? im just getting server-timeouts when i try to connect to the svn soucre.